Attention is currently required from: Edward O'Callaghan, Anastasia Klimchuk.

View Change

2 comments:

• File layout.c:

  • Patch Set #1, Line 296: layout->entries[i].included = false;

    Should this line also move into flashrom_layout_release() ?

    Even better, zero the whole entry.

  • Patch Set #1, Line 279: layout_cleanup_args

    This function is not cleaning up the layout anymore, only args. […]

    It's still layout args specifically so I'd like to keep 'layout', but layout_args_cleanup seems a little better.

To view, visit change 54147. To unsubscribe, or for help writing mail filters, visit settings.