Attention is currently required from: Nico Huber, Edward O'Callaghan, Anastasia Klimchuk. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/52557 )
Change subject: dummyflasher.c: Fix memory leak on shutdown ......................................................................
Patch Set 1: Code-Review+2
(4 comments)
Patchset:
PS1: +2 because the patch does what the commit message says, but I noticed some more issues. I'm fine with fixing them in separate commits.
File dummyflasher.c:
https://review.coreboot.org/c/flashrom/+/52557/comment/77c93734_f899fb6a PS1, Line 716: return 1; Doesn't `data` leak here as well? And also in the other return paths.
https://review.coreboot.org/c/flashrom/+/52557/comment/e94bc837_a85b1320 PS1, Line 982: free(status); For another patch: this is the same story as CB:46551
https://review.coreboot.org/c/flashrom/+/52557/comment/dbeb100e_0053c97f PS1, Line 986: return 1; `flashchip_contents` also leaks here. We could also move this check to run before the malloc() call. I would suggest fixing this in a separate commit.
-
Angel Pons (Code Review)