Attention is currently required from: Nico Huber, Edward O'Callaghan, Anastasia Klimchuk.
Patch set 1:Code-Review +2
4 comments:
Patchset:
+2 because the patch does what the commit message says, but I noticed some more issues. I'm fine with fixing them in separate commits.
File dummyflasher.c:
Patch Set #1, Line 716: return 1;
Doesn't `data` leak here as well? And also in the other return paths.
Patch Set #1, Line 982: free(status);
For another patch: this is the same story as CB:46551
Patch Set #1, Line 986: return 1;
`flashchip_contents` also leaks here. We could also move this check to run before the malloc() call. I would suggest fixing this in a separate commit.
To view, visit change 52557. To unsubscribe, or for help writing mail filters, visit settings.