Attention is currently required from: Dmitry Zhadinets, Peter Marheine.
Anastasia Klimchuk has posted comments on this change by Dmitry Zhadinets. ( https://review.coreboot.org/c/flashrom/+/86875?usp=email )
Change subject: libflashrom: Update the API for Logger Callback
......................................................................
Patch Set 8: Code-Review+2
(1 comment)
File libflashrom.c:
https://review.coreboot.org/c/flashrom/+/86875/comment/3668c62c_79a7c0a7?usp... :
PS4, Line 59: /* Dynamic messages and double formatting may not be ideal,
: as they are slow. It would be better to limit the message
: size to a fixed value (e.g., char message[1024] = {0};). */
Done
Peter, I wanted to check, do you agree with how this ended up looking like? No dynamic allocation, however no silent dropping either (an error is returned)
--
To view, visit
https://review.coreboot.org/c/flashrom/+/86875?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: flashrom
Gerrit-Branch: main
Gerrit-Change-Id: Iea738bd371fa3d69b9cf222c89ee67490d30af39
Gerrit-Change-Number: 86875
Gerrit-PatchSet: 8
Gerrit-Owner: Dmitry Zhadinets
dzhadinets@gmail.com
Gerrit-Reviewer: Anastasia Klimchuk
aklm@chromium.org
Gerrit-Reviewer: Peter Marheine
pmarheine@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Dmitry Zhadinets
dzhadinets@gmail.com
Gerrit-Attention: Peter Marheine
pmarheine@chromium.org
Gerrit-Comment-Date: Sun, 30 Mar 2025 12:33:26 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Dmitry Zhadinets
dzhadinets@gmail.com
Comment-In-Reply-To: Anastasia Klimchuk
aklm@chromium.org
Comment-In-Reply-To: Peter Marheine
pmarheine@chromium.org