Attention is currently required from: Dmitry Zhadinets, Peter Marheine.

Patch set 8:Code-Review +2

View Change

1 comment:

• File libflashrom.c:

  • Patch Set #4, Line 59:

    	/* Dynamic messages and double formatting may not be ideal,
    	as they are slow. It would be better to limit the message
    	size to a fixed value (e.g., char message[1024] = {0};). */
    

    Done

    Peter, I wanted to check, do you agree with how this ended up looking like? No dynamic allocation, however no silent dropping either (an error is returned)

To view, visit change 86875. To unsubscribe, or for help writing mail filters, visit settings.