Attention is currently required from: Edward O'Callaghan.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/71621 )
Change subject: internal.c: Have preinit hook do cpu and bus init ......................................................................
Patch Set 1: Code-Review+1
(4 comments)
Commit Message:
https://review.coreboot.org/c/flashrom/+/71621/comment/bcbd22eb_8670ea2e PS1, Line 7: cpu Not sure why it says "Processor", but it seems inaccurate. Not this change's problem.
https://review.coreboot.org/c/flashrom/+/71621/comment/7cedb353_513ed060 PS1, Line 10: initalisation Insert an `i` after the first 4 letters: init_i_alisation
https://review.coreboot.org/c/flashrom/+/71621/comment/1c54aa0a_2dae6194 PS1, Line 11: initalise Insert an `i` after the first 4 letters: init_i_alise
File internal.c:
https://review.coreboot.org/c/flashrom/+/71621/comment/301c4c48_bf08dd51 PS1, Line 245: if (try_mtd(cfg) == 0) { : ret = 0; : goto internal_init_exit; : } We don't need to initialise PCI access or perform flash enables if we're using MTD, do we?
Actually, we want to run the flash enables for MTD too.