Attention is currently required from: Nico Huber, Edward O'Callaghan, Angel Pons, Anastasia Klimchuk. Peter Marheine has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/56911 )
Change subject: tests: add init_shutdown test for realtek_mst_i2c_spi ......................................................................
Patch Set 3:
(5 comments)
File tests/init_shutdown.c:
https://review.coreboot.org/c/flashrom/+/56911/comment/7f1bc964_1fec5f60 PS2, Line 307: 0x10ec
This number has some meaning, also I see it is used in other mocks, so surely it is important. […]
Done
https://review.coreboot.org/c/flashrom/+/56911/comment/faebd0d3_189b299f PS2, Line 319: printf("ioctl(0x10ec, I2C_SLAVE, %#lx)\n", addr);
This looks like a debugging statement, not sure we need it. […]
Done
https://review.coreboot.org/c/flashrom/+/56911/comment/f4196069_4fe656d8 PS2, Line 320: 0x4a
This number also needs a comment
Done
https://review.coreboot.org/c/flashrom/+/56911/comment/eb310661_16dda928 PS2, Line 341: printf("i2c set register address %#x\n", bytes_buf[0]); : return 1;
If you remove printf statements, this looks like one error path which returns -1 and one normal path […]
Done
https://review.coreboot.org/c/flashrom/+/56911/comment/dec2c946_ca5ee94e PS2, Line 365: T
typo
Done