Attention is currently required from: Nico Huber, Edward O'Callaghan, Angel Pons, Anastasia Klimchuk.

View Change

5 comments:

• File tests/init_shutdown.c:

  • Patch Set #2, Line 307: 0x10ec

    This number has some meaning, also I see it is used in other mocks, so surely it is important. […]

    Done

  • Patch Set #2, Line 319: printf("ioctl(0x10ec, I2C_SLAVE, %#lx)\n", addr);

    This looks like a debugging statement, not sure we need it. […]

    Done

  • Patch Set #2, Line 320: 0x4a

    This number also needs a comment

    Done

  • Patch Set #2, Line 341:

    printf("i2c set register address %#x\n", bytes_buf[0]);
    		return 1;
    

    If you remove printf statements, this looks like one error path which returns -1 and one normal path […]

    Done

  • Patch Set #2, Line 365: T

    typo

    Done

To view, visit change 56911. To unsubscribe, or for help writing mail filters, visit settings.