[M] Change in flashrom[main]: flashchips: Add support for GigaDevice GD25LR256E, GD251R512ME

[Anastasia Klimchuk (Code Review)]

Attention is currently required from: Angel Pons, Martin L Roth, Martin Roth, Peter Marheine, Raj Astekar, Ravishankar Sarawadi, Wonkyu Kim.

Anastasia Klimchuk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/58025?usp=email )

Change subject: flashchips: Add support for GigaDevice GD25LR256E, GD251R512ME
......................................................................

Patch Set 8:

(10 comments)

Patchset:

PS8:
> I read through the comments thread to recall what the patch have been waiting for. […]

Many thanks to Victor on the mailing list for giving datasheets, I did a review and added some comments.

File flashchips.c:

https://review.coreboot.org/c/flashrom/+/58025/comment/76651360_3fec0d74 :
PS8, Line 6552: .name           = "GD25LR256E",
This is out of order, both entries need to be moved after GD25LQ80 and just before GD25Q10

https://review.coreboot.org/c/flashrom/+/58025/comment/0deca606_33434b56 :
PS8, Line 6590: SPI_PRETTYPRINT_STATUS_REGISTER_BP3_SRWD
Datasheet has BP4, so this should be `SPI_PRETTYPRINT_STATUS_REGISTER_BP4_SRWD`

https://review.coreboot.org/c/flashrom/+/58025/comment/343681e1_32b6595a :
PS8, Line 6591: SPI_DISABLE_BLOCKPROTECT
SPI_DISABLE_BLOCKPROTECT_BP4_SRWD

https://review.coreboot.org/c/flashrom/+/58025/comment/e256659a_175ff710 :
PS8, Line 6594: {1600, 2000}
Slight correction : from datasheet it's 1.65~2.0V

https://review.coreboot.org/c/flashrom/+/58025/comment/69474edd_5fc8758d :
PS8, Line 6599: .tb     = {STATUS1, 6, RW},
In such cases you should add a comment:

`Called BP4 in datasheet, acts like TB`

https://review.coreboot.org/c/flashrom/+/58025/comment/4ea82095_fcd0841a :
PS8, Line 6646: SPI_PRETTYPRINT_STATUS_REGISTER_BP3_SRWD
SPI_PRETTYPRINT_STATUS_REGISTER_BP4_SRWD

https://review.coreboot.org/c/flashrom/+/58025/comment/f67121aa_1a0a7e2d :
PS8, Line 6647: SPI_DISABLE_BLOCKPROTECT
SPI_DISABLE_BLOCKPROTECT_BP4_SRWD

https://review.coreboot.org/c/flashrom/+/58025/comment/b194c85c_4bf5c3fd :
PS8, Line 6650: {1600, 2000},
1.65~2.0V

https://review.coreboot.org/c/flashrom/+/58025/comment/410965dc_2c5da58a :
PS8, Line 6655: .tb     = {STATUS1, 6, RW},
Also as above, needs a comment:

`Called BP4 in datasheet, acts like TB`