Attention is currently required from: Angel Pons, Martin L Roth, Martin Roth, Peter Marheine, Raj Astekar, Ravishankar Sarawadi, Wonkyu Kim.
10 comments:
Patchset:
I read through the comments thread to recall what the patch have been waiting for. […]
Many thanks to Victor on the mailing list for giving datasheets, I did a review and added some comments.
File flashchips.c:
Patch Set #8, Line 6552: .name = "GD25LR256E",
This is out of order, both entries need to be moved after GD25LQ80 and just before GD25Q10
Patch Set #8, Line 6590: SPI_PRETTYPRINT_STATUS_REGISTER_BP3_SRWD
Datasheet has BP4, so this should be `SPI_PRETTYPRINT_STATUS_REGISTER_BP4_SRWD`
Patch Set #8, Line 6591: SPI_DISABLE_BLOCKPROTECT
SPI_DISABLE_BLOCKPROTECT_BP4_SRWD
Patch Set #8, Line 6594: {1600, 2000}
Slight correction : from datasheet it's 1.65~2.0V
Patch Set #8, Line 6599: .tb = {STATUS1, 6, RW},
In such cases you should add a comment:
`Called BP4 in datasheet, acts like TB`
Patch Set #8, Line 6646: SPI_PRETTYPRINT_STATUS_REGISTER_BP3_SRWD
SPI_PRETTYPRINT_STATUS_REGISTER_BP4_SRWD
Patch Set #8, Line 6647: SPI_DISABLE_BLOCKPROTECT
SPI_DISABLE_BLOCKPROTECT_BP4_SRWD
Patch Set #8, Line 6650: {1600, 2000},
1.65~2.0V
Patch Set #8, Line 6655: .tb = {STATUS1, 6, RW},
Also as above, needs a comment:
`Called BP4 in datasheet, acts like TB`
To view, visit change 58025. To unsubscribe, or for help writing mail filters, visit settings.