Attention is currently required from: Anastasia Klimchuk, Peter Marheine, Thomas Heijligen.
Brian Norris has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/81545?usp=email )
Change subject: udelay: only use OS time for delays, except on DOS ......................................................................
Patch Set 4:
(2 comments)
File meson.build:
https://review.coreboot.org/c/flashrom/+/81545/comment/83756100_30849eb3 : PS4, Line 121: DHAVE_NANOSLEEP=1
I didn't find this to be ever defined in Makefile, is it right? I thought there would be something i […]
yeah, maybe something similar to the `Makefile.d/clock_gettime_test.c` test? frankly, it's easy to get lazy and incomplete [*] when there are two build systems, for some reason...
[*] speaking from experience
File udelay.c:
https://review.coreboot.org/c/flashrom/+/81545/comment/47ccbdf1_dd3d0200 : PS4, Line 76: timeusec I'm gonna say you probably didn't test this part 😜
-
Brian Norris (Code Review)