Attention is currently required from: Anastasia Klimchuk, Peter Marheine, Thomas Heijligen.
View Change
2 comments:
File meson.build:
Patch Set #4, Line 121: DHAVE_NANOSLEEP=1
I didn't find this to be ever defined in Makefile, is it right? I thought there would be something i […]
yeah, maybe something similar to the `Makefile.d/clock_gettime_test.c` test? frankly, it's easy to get lazy and incomplete [*] when there are two build systems, for some reason...
[*] speaking from experience
File udelay.c:
To view, visit change 81545. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-Project: flashrom
Gerrit-Branch: main
Gerrit-Change-Id: I7ac5450d194a475143698d65d64d8bcd2fd25e3f
Gerrit-Change-Number: 81545
Gerrit-PatchSet: 4
Gerrit-Owner: Peter Marheine <pmarheine@chromium.org>
Gerrit-Reviewer: Anastasia Klimchuk <aklm@chromium.org>
Gerrit-Reviewer: Brian Norris <briannorris@chromium.org>
Gerrit-Reviewer: Thomas Heijligen <src@posteo.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-Attention: Thomas Heijligen <src@posteo.de>
Gerrit-Attention: Anastasia Klimchuk <aklm@chromium.org>
Gerrit-Attention: Peter Marheine <pmarheine@chromium.org>
Gerrit-Comment-Date: Tue, 02 Apr 2024 21:21:52 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Anastasia Klimchuk <aklm@chromium.org>
Gerrit-MessageType: comment