Thomas Heijligen has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/64224 )
Change subject: tests: Rearange CPP guards ......................................................................
Patch Set 2:
(1 comment)
File tests/lifecycle.c:
https://review.coreboot.org/c/flashrom/+/64224/comment/a3f7fe5d_c679e6a8 PS2, Line 87: #if CONFIG_DUMMY == 1
We could get rid of the pre-processor conditionals by splitting up the file into per-driver compilat […]
Splitting the file is a good idea. I would be careful with the use of weak symbols. Sometimes they behave unexpectedly. As long as we have the CONFIG_* symbols we can also use them here. We could do the same as in programmer_table.c for the first step. Beside that I will not consider this as part of this change here.
-
Thomas Heijligen (Code Review)