View Change

1 comment:

• File tests/lifecycle.c:

  • Patch Set #2, Line 87: #if CONFIG_DUMMY == 1

    We could get rid of the pre-processor conditionals by splitting up the file into per-driver compilat […]

    Splitting the file is a good idea. I would be careful with the use of weak symbols. Sometimes they behave unexpectedly. As long as we have the CONFIG_* symbols we can also use them here. We could do the same as in programmer_table.c for the first step.
    Beside that I will not consider this as part of this change here.

To view, visit change 64224. To unsubscribe, or for help writing mail filters, visit settings.