Attention is currently required from: Edward O'Callaghan.
Anastasia Klimchuk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/70603 )
Change subject: flashrom.c: Reduce the prog global state machine ......................................................................
Patch Set 3: Code-Review+2
(1 comment)
File flashrom.c:
https://review.coreboot.org/c/flashrom/+/70603/comment/4d25837b_6bea2f7f PS1, Line 41: g_programmer_type
Well this is ephemeral, I wouldn't wrangle over the perfect name, the `_type` suffix is meant to giv […]
I thought about the naming for some time. On one hand, yes it's hard to guess that `programmer_type` indicates a boolean var. On the other hand, there is only one usage of this var, which is inside `is_internal_programmer()` and the function `is_internal_programmer()` should be used everywhere (not the variable). So, I am fine with this as is. And longer term plan is to get rid of it anyway.
-
Anastasia Klimchuk (Code Review)