Attention is currently required from: Edward O'Callaghan.

Patch set 3:Code-Review +2

View Change

1 comment:

• File flashrom.c:

  • Patch Set #1, Line 41: g_programmer_type

    Well this is ephemeral, I wouldn't wrangle over the perfect name, the `_type` suffix is meant to giv […]

    I thought about the naming for some time. On one hand, yes it's hard to guess that `programmer_type` indicates a boolean var. On the other hand, there is only one usage of this var, which is inside `is_internal_programmer()` and the function `is_internal_programmer()` should be used everywhere (not the variable).
    So, I am fine with this as is.
    And longer term plan is to get rid of it anyway.

To view, visit change 70603. To unsubscribe, or for help writing mail filters, visit settings.