Mike Banon has posted comments on this change. ( https://review.coreboot.org/23263 )
Change subject: Add support for reading the current flash contents from a file ......................................................................
Patch Set 7:
(2 comments)
https://review.coreboot.org/#/c/23263/6/flashrom.c File flashrom.c:
https://review.coreboot.org/#/c/23263/6/flashrom.c@2395 PS6, Line 2395: if (refcontents && oldcontents) { : msg_cinfo("Assuming old flash chip contents as ref-file...\n"); : memcpy(oldcontents, refcontents, flash_size); : memcpy(curcontents, refcontents, flash_size); : } else {
Code flow is still not correct, or at least is more limited than […]
Will be done at the next patch set
https://review.coreboot.org/#/c/23263/6/flashrom.c@2578 PS6, Line 2578: goto _free_ret;
Um, I shouldn't have started talking about `const` I guess. I see […]
Also will be done at the next patch set