View Change
2 comments:
File flashrom.c:
Patch Set #6, Line 2395:
if (refcontents && oldcontents) {
msg_cinfo("Assuming old flash chip contents as ref-file...\n");
memcpy(oldcontents, refcontents, flash_size);
memcpy(curcontents, refcontents, flash_size);
} else {
Code flow is still not correct, or at least is more limited than […]
Will be done at the next patch set
Patch Set #6, Line 2578: goto _free_ret;
Um, I shouldn't have started talking about `const` I guess. I see […]
Also will be done at the next patch set
To view, visit change 23263. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Idf153b6955f37779ae9bfb228a434ed10c304947
Gerrit-Change-Number: 23263
Gerrit-PatchSet: 7
Gerrit-Owner: Mike Banon <mikebdp2@gmail.com>
Gerrit-Reviewer: David Hendricks <david.hendricks@gmail.com>
Gerrit-Reviewer: Mike Banon <mikebdp2@gmail.com>
Gerrit-Reviewer: Nico Huber <nico.h@gmx.de>
Gerrit-Reviewer: Paul Kocialkowski <contact@paulk.fr>
Gerrit-Reviewer: Paul Menzel <paulepanter@users.sourceforge.net>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-Comment-Date: Mon, 05 Feb 2018 23:04:53 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No