Nico Huber has posted comments on this change. ( https://review.coreboot.org/20922 )
Change subject: chispet_enable: Add support for C620-series Lewisburg PCH ......................................................................
Patch Set 4:
(5 comments)
https://review.coreboot.org/#/c/20922/4/ich_descriptors.c File ich_descriptors.c:
https://review.coreboot.org/#/c/20922/4/ich_descriptors.c@371 PS4, Line 371: if (cs == CHIPSET_100_SERIES_SUNRISE_POINT) { missing C620 here
https://review.coreboot.org/#/c/20922/4/ich_descriptors.c@373 PS4, Line 373: EC EC/BMC?
https://review.coreboot.org/#/c/20922/4/ich_descriptors.c@373 PS4, Line 373: unknown 4th region is Device Expansion, DE?
https://review.coreboot.org/#/c/20922/4/ich_descriptors.c@373 PS4, Line 373: , We have to add a sixth region, "unknown", or we'd run into the check below.
https://review.coreboot.org/#/c/20922/4/ich_descriptors.c@381 PS4, Line 381: msg_pdbg2(" FD BIOS ME GbE Pltf Reg5 Reg6 Reg7 EC Reg9\n"); More regions, sigh.