Nico Huber posted comments on this change.

View Change

Patch set 4:

(5 comments)

• File ich_descriptors.c:

  • Patch Set #4, Line 371: if (cs == CHIPSET_100_SERIES_SUNRISE_POINT) {

    missing C620 here

  • Patch Set #4, Line 373: EC

    EC/BMC?

  • Patch Set #4, Line 373: unknown

    4th region is Device Expansion, DE?

  • Patch Set #4, Line 373: ,

    We have to add a sixth region, "unknown", or we'd run into the
    check below.

  • Patch Set #4, Line 381: msg_pdbg2(" FD BIOS ME GbE Pltf Reg5 Reg6 Reg7 EC Reg9\n");

    More regions, sigh.

To view, visit change 20922. To unsubscribe, visit settings.