Nico Huber has posted comments on this change. ( https://review.coreboot.org/23346 )
Change subject: cli_classic: Add --chip-size command ......................................................................
Patch Set 3: Code-Review+2
(2 comments)
https://review.coreboot.org/#/c/23346/3//COMMIT_MSG Commit Message:
https://review.coreboot.org/#/c/23346/3//COMMIT_MSG@9 PS3, Line 9: This adds a command to print the size of the detected flash chip (in bytes). Line is too long :-P
https://review.coreboot.org/#/c/23346/2/cli_classic.c File cli_classic.c:
https://review.coreboot.org/#/c/23346/2/cli_classic.c@129 PS2, Line 129: 0x0101
Change this (and the one for --ifd) to use an enum?
Good idea. I also thought about making the operation a single variable (with a bitmask enum), currently *_it and chip_size are all mutually exclusive booleans.
-
Nico Huber (Code Review)