Patch set 3:Code-Review +2

View Change

2 comments:

• Commit Message:

  • Patch Set #3, Line 9: This adds a command to print the size of the detected flash chip (in bytes).

    Line is too long :-P

• File cli_classic.c:

  • Patch Set #2, Line 129: 0x0101

    Change this (and the one for --ifd) to use an enum?

    Good idea. I also thought about making the operation a single variable
    (with a bitmask enum), currently *_it and chip_size are all mutually
    exclusive booleans.

To view, visit change 23346. To unsubscribe, or for help writing mail filters, visit settings.