Attention is currently required from: Anastasia Klimchuk.
Dmitry Zhadinets has posted comments on this change by Dmitry Zhadinets. ( https://review.coreboot.org/c/flashrom/+/86921?usp=email )
Change subject: libflashrom: Added API to enumerate supported programmers ......................................................................
Patch Set 6:
(5 comments)
Patchset:
PS3:
I realised that by now I already added comments to all three patches in the chain, hope it's fine. […]
Looks like your link does not work. Could you check?
File libflashrom.c:
https://review.coreboot.org/c/flashrom/+/86921/comment/216b2b88_d00576ec?usp... : PS3, Line 147:
no space here
Done
https://review.coreboot.org/c/flashrom/+/86921/comment/cee4d53a_79a7f176?usp... : PS3, Line 159: const char *flashrom_get_programmer_name(int n) : { : if (n < 0 || (size_t)n >= programmer_table_size) : return NULL; : return programmer_table[n]->name; : }
Why this is needed? Client can get the n-th name using the function just above `flashrom_supported_p […]
It is because of my squashed commits. I re-based it not is it here in another commit. Lets discuss it there. https://review.coreboot.org/c/flashrom/+/86947/3 It was requested by Peter here https://review.coreboot.org/c/flashrom/+/86921/comment/305f6656_3d9d7212/
File tests/libflashrom.c:
https://review.coreboot.org/c/flashrom/+/86921/comment/0d7fe06f_70fd3595?usp... : PS3, Line 40: #if CONFIG_DUMMY == 1
For tests, dummy is always included, you can remove this check
Again, my swashed commits . it is here now https://review.coreboot.org/c/flashrom/+/86946/3 Removed there
https://review.coreboot.org/c/flashrom/+/86921/comment/c5e7a483_9ae840e3?usp... : PS3, Line 62:
This needs to be tabs (instead of spaces).
Fixed here https://review.coreboot.org/c/flashrom/+/86947/3