Attention is currently required from: Anastasia Klimchuk.

View Change

5 comments:

• Patchset:

  • Patch Set #3:

    I realised that by now I already added comments to all three patches in the chain, hope it's fine. […]

    Looks like your link does not work. Could you check?

• File libflashrom.c:

  • Patch Set #3, Line 147:

    no space here

    Done

  • Patch Set #3, Line 159:

    const char *flashrom_get_programmer_name(int n)
    {
    	if (n < 0 || (size_t)n >= programmer_table_size)
    		return NULL;
    	return programmer_table[n]->name;
    }
    

    Why this is needed? Client can get the n-th name using the function just above `flashrom_supported_p […]

    It is because of my squashed commits. I re-based it not is it here in another commit. Lets discuss it there.
    https://review.coreboot.org/c/flashrom/+/86947/3
    It was requested by Peter here
    https://review.coreboot.org/c/flashrom/+/86921/comment/305f6656_3d9d7212/

• File tests/libflashrom.c:

  • Patch Set #3, Line 40: #if CONFIG_DUMMY == 1

    For tests, dummy is always included, you can remove this check

    Again, my swashed commits . it is here now https://review.coreboot.org/c/flashrom/+/86946/3
    Removed there

  • Patch Set #3, Line 62:

    This needs to be tabs (instead of spaces).

    Fixed here https://review.coreboot.org/c/flashrom/+/86947/3

To view, visit change 86921. To unsubscribe, or for help writing mail filters, visit settings.