Attention is currently required from: Anastasia Klimchuk, David Hendricks, Kyösti Mälkki, Patrick Georgi, Patrick Rudolph.
Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/78186?usp=email )
Change subject: ichspi: Add support for C740 PCH ......................................................................
Patch Set 4:
(3 comments)
File ich_descriptors.c:
https://review.coreboot.org/c/flashrom/+/78186/comment/fee8885f_f805e7fe : PS4, Line 1024: if (content->ISL <= 80) : return CHIPSET_C620_SERIES_LEWISBURG
I am a bit confused, what happens with support for LEWISBURG ? Why are you just removing it? […]
It's not removed. This code path is never taken on C620 as ICCRIBA==0x34. C620 is still being detected in the code path below.
https://review.coreboot.org/c/flashrom/+/78186/comment/23abf067_6866f2a2 : PS4, Line 490: to be compatible with 500 Series PCH below
Maybe "to align with the SPI programming guide, which also conveniently makes it compatible with 500 […]
It says there are 6 masters (thus NM=6), but can only name 5. If there's a 6th then it's undocumented. However the first 5 are matching '500 Series PCH' and since C740 is a 500 Series clone Intel probably only forget to update this field when writing the document. So it's not aligning with the SPI programming guide. It's more like fixing it?
https://review.coreboot.org/c/flashrom/+/78186/comment/f39d3c5f_d857ef98 : PS4, Line 1039: return CHIPSET_C740_SERIES_EMMITSBURG;
For Lewisburg the ISL value should be 0x8b (139) (see also: CB:57581). […]
This code path is never taken on C620 as ICCRIBA==0x34
-
Patrick Rudolph (Code Review)