Attention is currently required from: Anastasia Klimchuk, David Hendricks, Kyösti Mälkki, Patrick Georgi, Patrick Rudolph.
3 comments:
File ich_descriptors.c:
if (content->ISL <= 80)
return CHIPSET_C620_SERIES_LEWISBURG
I am a bit confused, what happens with support for LEWISBURG ? Why are you just removing it? […]
It's not removed. This code path is never taken on C620 as ICCRIBA==0x34.
C620 is still being detected in the code path below.
Patch Set #4, Line 490: to be compatible with 500 Series PCH below
Maybe "to align with the SPI programming guide, which also conveniently makes it compatible with 500 […]
It says there are 6 masters (thus NM=6), but can only name 5. If there's a 6th then it's undocumented. However the first 5 are matching '500 Series PCH' and since C740 is a 500 Series clone Intel probably only forget to update this field when writing the document.
So it's not aligning with the SPI programming guide. It's more like fixing it?
Patch Set #4, Line 1039: return CHIPSET_C740_SERIES_EMMITSBURG;
For Lewisburg the ISL value should be 0x8b (139) (see also: CB:57581). […]
This code path is never taken on C620 as ICCRIBA==0x34
To view, visit change 78186. To unsubscribe, or for help writing mail filters, visit settings.