Attention is currently required from: Nico Huber, Angel Pons. Miklós Márton has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/56636 )
Change subject: ni845x_spi: handle PROGRAMFILES(X86) env var properly ......................................................................
Patch Set 1:
(2 comments)
Patchset:
PS1:
What I remember from the original review: we used the ${} notation to avoid trouble […]
My build VM used during the review was a Windows 7 based one, and now I built a new VM with Windows 10. I have to admit that I have not noted the mingw version used during the review so this might differ from the two setups. Other than these it might be possible that the I simply overlooked the weird -I and -L arguments since it does not harm anything, just looks weird.
File Makefile:
https://review.coreboot.org/c/flashrom/+/56636/comment/a9cd3e48_75dd899a PS1, Line 750: X
Did the casing change? X instead of x
Yes env lists with upper case X.
-
Miklós Márton (Code Review)