Attention is currently required from: Nico Huber, Angel Pons.

View Change

2 comments:

• Patchset:

  • Patch Set #1:

    What I remember from the original review: we used the ${} notation to avoid trouble […]

    My build VM used during the review was a Windows 7 based one, and now I built a new VM with Windows 10. I have to admit that I have not noted the mingw version used during the review so this might differ from the two setups. Other than these it might be possible that the I simply overlooked the weird -I and -L arguments since it does not harm anything, just looks weird.

• File Makefile:

  • Patch Set #1, Line 750: X

    Did the casing change? X instead of x

    Yes env lists with upper case X.

To view, visit change 56636. To unsubscribe, or for help writing mail filters, visit settings.