Jacob Garber has uploaded this change for review. ( https://review.coreboot.org/c/flashrom/+/33815
Change subject: cli_classic: Remove old usage warning ......................................................................
cli_classic: Remove old usage warning
We are at version 1.1 now, and 0.9.6 was released all the way back in 2012, so it is safe to remove this warning.
Change-Id: If1b379b7b8234d50a2f0a4f522f15820a1a6603c Signed-off-by: Jacob Garber jgarber1@ualberta.ca --- M cli_classic.c 1 file changed, 0 insertions(+), 3 deletions(-)
git pull ssh://review.coreboot.org:29418/flashrom refs/changes/15/33815/1
diff --git a/cli_classic.c b/cli_classic.c index 2e07612..1182ab1 100644 --- a/cli_classic.c +++ b/cli_classic.c @@ -31,9 +31,6 @@
static void cli_classic_usage(const char *name) { - printf("Please note that the command line interface for flashrom has changed between\n" - "0.9.5 and 0.9.6 and will change again before flashrom 1.0.\n\n"); - printf("Usage: %s [-h|-R|-L|" #if CONFIG_PRINT_WIKI == 1 "-z|"
Hello build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/flashrom/+/33815
to look at the new patch set (#2).
Change subject: cli_classic: Remove old usage warnings ......................................................................
cli_classic: Remove old usage warnings
We are at version 1.1 now, and the user interface change in 0.9.6 was to make setting the programmer mandatory. This was done all the way back in 2012, so it is safe to remove these warnings now.
Change-Id: If1b379b7b8234d50a2f0a4f522f15820a1a6603c Signed-off-by: Jacob Garber jgarber1@ualberta.ca --- M cli_classic.c 1 file changed, 0 insertions(+), 4 deletions(-)
git pull ssh://review.coreboot.org:29418/flashrom refs/changes/15/33815/2
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/33815 )
Change subject: cli_classic: Remove old usage warnings ......................................................................
Patch Set 2: Code-Review+2
Nico Huber has submitted this change and it was merged. ( https://review.coreboot.org/c/flashrom/+/33815 )
Change subject: cli_classic: Remove old usage warnings ......................................................................
cli_classic: Remove old usage warnings
We are at version 1.1 now, and the user interface change in 0.9.6 was to make setting the programmer mandatory. This was done all the way back in 2012, so it is safe to remove these warnings now.
Change-Id: If1b379b7b8234d50a2f0a4f522f15820a1a6603c Signed-off-by: Jacob Garber jgarber1@ualberta.ca Reviewed-on: https://review.coreboot.org/c/flashrom/+/33815 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Nico Huber nico.h@gmx.de --- M cli_classic.c 1 file changed, 0 insertions(+), 4 deletions(-)
Approvals: build bot (Jenkins): Verified Nico Huber: Looks good to me, approved
diff --git a/cli_classic.c b/cli_classic.c index 2e07612..b79f953 100644 --- a/cli_classic.c +++ b/cli_classic.c @@ -31,9 +31,6 @@
static void cli_classic_usage(const char *name) { - printf("Please note that the command line interface for flashrom has changed between\n" - "0.9.5 and 0.9.6 and will change again before flashrom 1.0.\n\n"); - printf("Usage: %s [-h|-R|-L|" #if CONFIG_PRINT_WIKI == 1 "-z|" @@ -480,7 +477,6 @@ programmer_table[CONFIG_DEFAULT_PROGRAMMER].name, pparam); } else { msg_perr("Please select a programmer with the --programmer parameter.\n" - "Previously this was not necessary because there was a default set.\n" #if CONFIG_INTERNAL == 1 "To choose the mainboard of this computer use 'internal'. " #endif
-
Jacob Garber (Code Review) -
Nico Huber (Code Review)