[M] Change in flashrom[master]: tests/chip: Add non-aligned write within a region unit-test
Attention is currently required from: Sam McNally, Anastasia Klimchuk, Evan Benn.
Edward O'Callaghan has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/71659 )
Change subject: tests/chip: Add non-aligned write within a region unit-test ......................................................................
Patch Set 5:
(6 comments)
File tests/chip.c:
https://review.coreboot.org/c/flashrom/+/71659/comment/170e0c22_0910e6ef PS2, Line 469: * {MOCK_CHIP_SUBREGION_CONTENTS} [..] {MOCK_CHIP_SUBREGION_CONTENTS}.
I dont understand this: […]
Done
File tests/chip.c:
https://review.coreboot.org/c/flashrom/+/71659/comment/93405606_c3190b1c PS4, Line 443: /* FIXME: MOCK_CHIP_CONTENT is buggy within setup_chip, it should also
should this comment be here? if its buggy does the test work? what bug?
yes the test works, its a bug to do with setup_chip(). I don't know why, so I just left a comment here.
https://review.coreboot.org/c/flashrom/+/71659/comment/aa83030b_02d88d6b PS4, Line 457: /* Expect to verify the write completed successfuly within the region. */
is the presence of these flags important for catching the bug? […]
Done
https://review.coreboot.org/c/flashrom/+/71659/comment/77c0e8b0_f8e2e7e1 PS4, Line 469: * Create subregion smaller than erase granularity of chip.
subregion -> region whole file replace please
Done
https://review.coreboot.org/c/flashrom/+/71659/comment/ab5c0463_0d6e8f4b PS4, Line 498: /* .. */
remove
Done
https://review.coreboot.org/c/flashrom/+/71659/comment/b3b4eece_232192e4 PS4, Line 500: /* Expect a verification pass that content within the region however
this doesnt make sense
Done
-
Edward O'Callaghan (Code Review)