Attention is currently required from: Sam McNally, Anastasia Klimchuk, Evan Benn.

View Change

6 comments:

• File tests/chip.c:

  • Patch Set #2, Line 469: * {MOCK_CHIP_SUBREGION_CONTENTS} [..] {MOCK_CHIP_SUBREGION_CONTENTS}.

    I dont understand this: […]

    Done

• File tests/chip.c:

  • Patch Set #4, Line 443: /* FIXME: MOCK_CHIP_CONTENT is buggy within setup_chip, it should also

    should this comment be here? if its buggy does the test work? what bug?

    yes the test works, its a bug to do with setup_chip(). I don't know why, so I just left a comment here.

  • Patch Set #4, Line 457: /* Expect to verify the write completed successfuly within the region. */

    is the presence of these flags important for catching the bug? […]

    Done

  • Patch Set #4, Line 469: * Create subregion smaller than erase granularity of chip.

    subregion -> region whole file replace please

    Done

  • Patch Set #4, Line 498: /* .. */

    remove

    Done

  • Patch Set #4, Line 500: /* Expect a verification pass that content within the region however

    this doesnt make sense

    Done

To view, visit change 71659. To unsubscribe, or for help writing mail filters, visit settings.