Attention is currently required from: Thomas Heijligen, Angel Pons. Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/61034 )
Change subject: [RFC][WIP] Makefile: use directory for object files ......................................................................
Patch Set 1:
(3 comments)
Commit Message:
https://review.coreboot.org/c/flashrom/+/61034/comment/e83d4084_6ddf2141 PS1, Line 11: Makefile in util/ich_descriptors_tool does this already. So it hides the object files but the final binary is still in the source dir? I'm not sure if that's a good role-model. Not sure how common it is, but I'm much used to a `build/` dir for everything.
File Makefile:
https://review.coreboot.org/c/flashrom/+/61034/comment/7d515c12_9531c34a PS1, Line 925: _create_OBJPATH Doesn't this trigger a re-build of everything every time?
https://review.coreboot.org/c/flashrom/+/61034/comment/244e328b_96b92aa6 PS1, Line 1093: -include $(OBJPATH)/$(OBJS:.o=.d) This needs `$(addprefix )`.
Or maybe just do it one time, e.g.
OBJS := $(addprefix $(OBJPATH)/,$(OBJS))
-
Nico Huber (Code Review)