Attention is currently required from: Thomas Heijligen, Angel Pons.

View Change

3 comments:

• Commit Message:

  • Patch Set #1, Line 11: Makefile in util/ich_descriptors_tool does this already.

    So it hides the object files but the final binary is still in the
    source dir? I'm not sure if that's a good role-model. Not sure how
    common it is, but I'm much used to a `build/` dir for everything.

• File Makefile:

  • Patch Set #1, Line 925: _create_OBJPATH

    Doesn't this trigger a re-build of everything every time?

  • Patch Set #1, Line 1093: -include $(OBJPATH)/$(OBJS:.o=.d)

    This needs `$(addprefix )`.

    Or maybe just do it one time, e.g.

        OBJS := $(addprefix $(OBJPATH)/,$(OBJS))

To view, visit change 61034. To unsubscribe, or for help writing mail filters, visit settings.