Attention is currently required from: Sam McNally, Rizwan Qureshi, Edward O'Callaghan, Angel Pons. Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/62251 )
Change subject: ichspi: Add Alder Lake support ......................................................................
Patch Set 13:
(2 comments)
Patchset:
PS12:
Probably best to start with a new enum and collapse down as a optimisation patch as a follow up rath […]
I don't know what you mean exactly with `collapse down`. I sometimes try to optimize such things and then only after writing one or two alternative versions realize that it doesn't get any better overall. Saying it's hard to predict the result of future work.
Also no idea what is half baked. So far we have kept compatible platforms together under one enum entry (with some exceptions, both false-positive and false-negatives, that slipped review). Breaking that pattern would seem inconsistent, or well, consistent with the inconsistency.
File ich_descriptors.c:
https://review.coreboot.org/c/flashrom/+/62251/comment/03f8a6de_7aef2101 PS12, Line 1041: return CHIPSET_600_SERIES_ALDER_POINT;
Please test the detection (easy to do with ich_descriptors_tool). For […]
Done
-
Nico Huber (Code Review)