Attention is currently required from: Sam McNally, Rizwan Qureshi, Edward O'Callaghan, Angel Pons.
2 comments:
Patchset:
Probably best to start with a new enum and collapse down as a optimisation patch as a follow up rath […]
I don't know what you mean exactly with `collapse down`. I sometimes
try to optimize such things and then only after writing one or two
alternative versions realize that it doesn't get any better overall.
Saying it's hard to predict the result of future work.
Also no idea what is half baked. So far we have kept compatible
platforms together under one enum entry (with some exceptions,
both false-positive and false-negatives, that slipped review).
Breaking that pattern would seem inconsistent, or well, consistent
with the inconsistency.
File ich_descriptors.c:
Patch Set #12, Line 1041: return CHIPSET_600_SERIES_ALDER_POINT;
Please test the detection (easy to do with ich_descriptors_tool). For […]
Done
To view, visit change 62251. To unsubscribe, or for help writing mail filters, visit settings.