[M] Change in flashrom[master]: Add support for VIA VL805 USB Controller flashing

[ChrisEric1 CECL (Code Review)]

Attention is currently required from: Thomas Heijligen, Edward O'Callaghan, Nicholas Chin.

ChrisEric1 CECL has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/72057 )

Change subject: Add support for VIA VL805 USB Controller flashing
......................................................................

Patch Set 18:

(10 comments)

File vl805.c:

https://review.coreboot.org/c/flashrom/+/72057/comment/4f66e642_91911aa2 
PS18, Line 58:
> drop \n line 58.

Done

https://review.coreboot.org/c/flashrom/+/72057/comment/f428c03a_7919772e 
PS18, Line 79: curwritecnt = min(4, writecnt - j);
> .. i.e. […]

Done

https://review.coreboot.org/c/flashrom/+/72057/comment/1fb54f7d_9f234418 
PS18, Line 107: programmer
> `_mcu_` ?

vl805_mcu_active? Ok (changed the 3 matches to compile)

https://review.coreboot.org/c/flashrom/+/72057/comment/439a17f3_bef788b8 
PS18, Line 117: /* Shutdown stuff. */
> remove, adds no value.

Done

https://review.coreboot.org/c/flashrom/+/72057/comment/84c6e6f1_ae37cef8 
PS18, Line 118: dev
> just pass `vl805_data->dev` it is already well-typed.

Done

https://review.coreboot.org/c/flashrom/+/72057/comment/1ff90547_cec9a51c 
PS18, Line 130: 	.write_aai	= default_spi_write_aai,
> no need for this default hook, see CB:67479

Done

https://review.coreboot.org/c/flashrom/+/72057/comment/a0fa6074_0f8e1a88 
PS18, Line 141:
> ditto

Done (removed \n)

https://review.coreboot.org/c/flashrom/+/72057/comment/4eb646f7_99631543 
PS18, Line 146:
> nit: drop this \n

Done

https://review.coreboot.org/c/flashrom/+/72057/comment/31ecb4f3_e5db08e8 
PS18, Line 158: vl805_programmer_active(dev, 0x1)
> you seem to toggle on on line 152, read fw rev, toggle off and then immediately back on again?

removed :

vl805_programmer_active(dev, 0x0);
    /* Some sort of init sequence, just copied from the logs. */
    vl805_programmer_active(dev, 0x1);

https://review.coreboot.org/c/flashrom/+/72057/comment/f9522c2e_d4b435dc 
PS18, Line 171: 	vl805_programmer_active(dev, 0x0);
              : 
              : 	vl805_programmer_active(dev, 0x1);
              :
> same here? if this is from a trace it could be from some silly OOP structure that always does a togg […]

removed:

vl805_programmer_active(dev, 0x0);
    vl805_programmer_active(dev, 0x1);