Attention is currently required from: Thomas Heijligen, Edward O'Callaghan, Nicholas Chin.

10 comments:

File vl805.c:
- Patch Set #18, Line 58:
  drop \n line 58.
  Done
- Patch Set #18, Line 79: curwritecnt = min(4, writecnt - j);
  .. i.e. […]
  Done
- Patch Set #18, Line 107: programmer
  `_mcu_` ?
  vl805_mcu_active? Ok (changed the 3 matches to compile)
- Patch Set #18, Line 117: /* Shutdown stuff. */
  remove, adds no value.
  Done
- Patch Set #18, Line 118: dev
  just pass `vl805_data->dev` it is already well-typed.
  Done
- Patch Set #18, Line 130: .write_aai = default_spi_write_aai,
  no need for this default hook, see CB:67479
  Done
- Patch Set #18, Line 141:
  ditto
  Done (removed \n)
- Patch Set #18, Line 146:
  nit: drop this \n
  Done
- Patch Set #18, Line 158: vl805_programmer_active(dev, 0x1)
  you seem to toggle on on line 152, read fw rev, toggle off and then immediately back on again?
  removed :
```
	vl805_programmer_active(dev, 0x0);
	/* Some sort of init sequence, just copied from the logs. */
	vl805_programmer_active(dev, 0x1);
```
- Patch Set #18, Line 171:
```
	vl805_programmer_active(dev, 0x0);

	vl805_programmer_active(dev, 0x1);
```
  same here? if this is from a trace it could be from some silly OOP structure that always does a togg […]
  removed:
```
	vl805_programmer_active(dev, 0x0);
	vl805_programmer_active(dev, 0x1);
```

To view, visit change 72057. To unsubscribe, or for help writing mail filters, visit settings.