David Hendricks has posted comments on this change. ( https://review.coreboot.org/22421 )
Change subject: spi_master: Introduce SPI_MASTER_4BA feature flag ......................................................................
Patch Set 6:
(1 comment)
I think I get what you were saying earlier... I don't know if it's worth blocking this patch, though. If you have time to implement the better approach by all means do so and I'll be happy to review it. I can take a swing at it too, but I probably won't get around to it for another month.
https://review.coreboot.org/#/c/22421/5/spi25.c File spi25.c:
https://review.coreboot.org/#/c/22421/5/spi25.c@380 PS5, Line 380: return -1;
I'm talking about the block erase commands. If the core read/erase/write […]
I'm not sure what the best solution will look like exactly... It seems sensible to build/maintain separate lists of commands that the chip and programmer support. The chips already do that, so it might not be much more effort to have the programmers do so. Most programmers won't be affected, but it makes sense to do it and also helps keep error handling tidy.
-
David Hendricks (Code Review)