I think I get what you were saying earlier... I don't know if it's worth blocking this patch, though. If you have time to implement the better approach by all means do so and I'll be happy to review it. I can take a swing at it too, but I probably won't get around to it for another month.

View Change

1 comment:

To view, visit change 22421. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ife66e3fc49b9716f9c99cad957095b528135ec2c
Gerrit-Change-Number: 22421
Gerrit-PatchSet: 6
Gerrit-Owner: Nico Huber <nico.h@gmx.de>
Gerrit-Reviewer: David Hendricks <david.hendricks@gmail.com>
Gerrit-Reviewer: Nico Huber <nico.h@gmx.de>
Gerrit-Reviewer: Paul Menzel <paulepanter@users.sourceforge.net>
Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer@coreboot.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-Comment-Date: Mon, 25 Dec 2017 10:08:56 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No