[L] Change in flashrom[master]: flashrom.c: Add functions for new erase selction algorithm
Attention is currently required from: Simon Buhrow, Edward O'Callaghan, Anastasia Klimchuk.
Aarya has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/65844 )
Change subject: flashrom.c: Add functions for new erase selction algorithm ......................................................................
Patch Set 85:
(4 comments)
File erasure_layout.h:
https://review.coreboot.org/c/flashrom/+/65844/comment/4f6dda7c_0359e859 PS83, Line 37: int erase_write(struct flashctx *const flashctx, chipoff_t region_start, chipoff_t region_end, uint8_t* curcontents, uint8_t* newcontents, struct erase_layout *erase_layout, bool *all_skipped);
We have a hard limit of 112 chars per line, this one is too long […]
Done
File erasure_layout.c:
https://review.coreboot.org/c/flashrom/+/65844/comment/b073eb50_298d58ff PS83, Line 203: ll->selected = need_erase(curcontents + start_addr, newcontents + start_addr, erase_len, flashctx->chip->gran, erased_value);
This line also exceeds 112 chars. […]
Done
File erasure_layout.c:
https://review.coreboot.org/c/flashrom/+/65844/comment/04103f34_124761ec PS84, Line 15: */
Add this `.c` file to both the Makefile and meson.build files so it gets built into object code.
Done
https://review.coreboot.org/c/flashrom/+/65844/comment/a341fed4_3a2a51e7 PS84, Line 74: int
`size_t` ?
Done
-
Aarya (Code Review)