Attention is currently required from: Simon Buhrow, Edward O'Callaghan, Anastasia Klimchuk.

View Change

4 comments:

• File erasure_layout.h:

  • Patch Set #83, Line 37: int erase_write(struct flashctx *const flashctx, chipoff_t region_start, chipoff_t region_end, uint8_t* curcontents, uint8_t* newcontents, struct erase_layout *erase_layout, bool *all_skipped);

    We have a hard limit of 112 chars per line, this one is too long […]

    Done

• File erasure_layout.c:

  • Patch Set #83, Line 203: ll->selected = need_erase(curcontents + start_addr, newcontents + start_addr, erase_len, flashctx->chip->gran, erased_value);

    This line also exceeds 112 chars. […]

    Done

• File erasure_layout.c:

  • Patch Set #84, Line 15: */

    Add this `.c` file to both the Makefile and meson.build files so it gets built into object code.

    Done

  • Patch Set #84, Line 74: int

    `size_t` ?

    Done

To view, visit change 65844. To unsubscribe, or for help writing mail filters, visit settings.