Attention is currently required from: Richard Hughes, Daniel Campello, Angel Pons, Anastasia Klimchuk, Patrick Rudolph. Edward O'Callaghan has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/49643 )
Change subject: libflashrom: Return progress state to the library user ......................................................................
Patch Set 17: Code-Review+1
(3 comments)
File include/libflashrom.h:
https://review.coreboot.org/c/flashrom/+/49643/comment/732d4a3c_a3693258 PS17, Line 78: struct flashrom_update_progress { : enum flashrom_progress_stage stage; : size_t current; : size_t total; : void *user_data; : }; should all this internal state be exposed to the user?
https://review.coreboot.org/c/flashrom/+/49643/comment/3919765d_a8294d14 PS17, Line 84: struct flashrom_flashctx; duplicates another forward declaration on line 205.
https://review.coreboot.org/c/flashrom/+/49643/comment/0c3c4eef_469d8e74 PS17, Line 85: struct flashrom_update_progress *progress_state I am a little confused on intended life-times here and why we have two copies of progress_state? We have one explicitly in the functions operands and another copy implicitly within the flashctx.
-
Edward O'Callaghan (Code Review)