Attention is currently required from: Richard Hughes, Daniel Campello, Angel Pons, Anastasia Klimchuk, Patrick Rudolph.

Patch set 17:Code-Review +1

View Change

3 comments:

• File include/libflashrom.h:

  • Patch Set #17, Line 78:

    struct flashrom_update_progress {
    	enum flashrom_progress_stage stage;
    	size_t current;
    	size_t total;
    	void *user_data;
    };
    

    should all this internal state be exposed to the user?

  • Patch Set #17, Line 84: struct flashrom_flashctx;

    duplicates another forward declaration on line 205.

  • Patch Set #17, Line 85: struct flashrom_update_progress *progress_state

    I am a little confused on intended life-times here and why we have two copies of progress_state? We have one explicitly in the functions operands and another copy implicitly within the flashctx.

To view, visit change 49643. To unsubscribe, or for help writing mail filters, visit settings.