Attention is currently required from: Anastasia Klimchuk, Edward O'Callaghan, Nikolai Artemiev, Thomas Heijligen.
Jes Klinke has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/77999?usp=email )
Change subject: raiden: Support target index with generic REQ_ENABLE ......................................................................
Patch Set 6:
(2 comments)
File doc/classic_cli_manpage.rst:
https://review.coreboot.org/c/flashrom/+/77999/comment/af002398_e135233b : PS5, Line 871:
trailing whitespace […]
Done
File tests/raiden_debug_spi.c:
https://review.coreboot.org/c/flashrom/+/77999/comment/05f2a7a9_5af85df4 : PS5, Line 112: : snprintf(raiden_debug_param, sizeof(raiden_debug_param), : "address=%d,target=AP", USB_DEVICE_ADDRESS); : run_basic_lifecycle(state, &raiden_debug_io, &programmer_raiden_debug_spi, raiden_debug_param); : : snprintf(raiden_debug_param, sizeof(raiden_debug_param), : "address=%d,target=ec", USB_DEVICE_ADDRESS); : run_basic_lifecycle(state, &raiden_debug_io, &programmer_raiden_debug_spi, raiden_debug_param); : : snprintf(raiden_debug_param, sizeof(raiden_debug_param), : "address=%d,target=0", USB_DEVICE_ADDRESS); : run_basic_lifecycle(state, &raiden_debug_io, &programmer_raiden_debug_spi, raiden_debug_param); : : snprintf(raiden_debug_param, sizeof(raiden_debug_param), : "address=%d,target=1", USB_DEVICE_ADDRESS); : run_basic_lifecycle(state, &raiden_debug_io, &programmer_raiden_debug_spi, raiden_debug_param);
This is great, thank you so much for adding test coverage! […]
Thanks for the good suggestions. Done.