Attention is currently required from: Anastasia Klimchuk, Edward O'Callaghan, Nikolai Artemiev, Thomas Heijligen.

View Change

2 comments:

• File doc/classic_cli_manpage.rst:

  • Patch Set #5, Line 871:

    trailing whitespace […]

    Done

• File tests/raiden_debug_spi.c:

  • Patch Set #5, Line 112:

    
    	snprintf(raiden_debug_param, sizeof(raiden_debug_param),
                     "address=%d,target=AP", USB_DEVICE_ADDRESS);
    	run_basic_lifecycle(state, &raiden_debug_io, &programmer_raiden_debug_spi, raiden_debug_param);
    
    	snprintf(raiden_debug_param, sizeof(raiden_debug_param),
                     "address=%d,target=ec", USB_DEVICE_ADDRESS);
    	run_basic_lifecycle(state, &raiden_debug_io, &programmer_raiden_debug_spi, raiden_debug_param);
    
    	snprintf(raiden_debug_param, sizeof(raiden_debug_param),
                     "address=%d,target=0", USB_DEVICE_ADDRESS);
    	run_basic_lifecycle(state, &raiden_debug_io, &programmer_raiden_debug_spi, raiden_debug_param);
    
    	snprintf(raiden_debug_param, sizeof(raiden_debug_param),
                     "address=%d,target=1", USB_DEVICE_ADDRESS);
    	run_basic_lifecycle(state, &raiden_debug_io, &programmer_raiden_debug_spi, raiden_debug_param);
    

    This is great, thank you so much for adding test coverage! […]

    Thanks for the good suggestions. Done.

To view, visit change 77999. To unsubscribe, or for help writing mail filters, visit settings.