Attention is currently required from: Nico Huber, Diana Zigterman, Edward O'Callaghan, Anastasia Klimchuk, Karthik Ramasubramanian.
Robert Zieba has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/62909 )
Change subject: raiden_debug_spi: Add more informative error message when WP is enabled
......................................................................
Patch Set 4:
(4 comments)
File raiden_debug_spi.c:
https://review.coreboot.org/c/flashrom/+/62909/comment/d9a9670f_dcd0ad73
PS3, Line 987:
trailing space
Done
https://review.coreboot.org/c/flashrom/+/62909/comment/aae994af_9988af5c
PS3, Line 987: /* Check if we received an error from the device. An error will have no response
: data, just the packet_id and status_code. */
While not expliticitly mentioned, even the Linux kernel accepts the […]
Done
https://review.coreboot.org/c/flashrom/+/62909/comment/96682e8e_d7f658b6
PS3, Line 989:
trailing space
Done
https://review.coreboot.org/c/flashrom/+/62909/comment/bb54fd2d_d282e4cb
PS3, Line 990: sizeof(struct usb_spi_response_v2) - USB_SPI_PAYLOAD_SIZE_V2_RESPONSE &&
: rsp_config.packet_v2.rsp_start.status_code != USB_SPI_SUCCESS) {
Could you please add one more tab before these two lines? It would be easier to visually distinguish […]
Done
--
To view, visit
https://review.coreboot.org/c/flashrom/+/62909
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: Ib1e8383baa9c3ea41ab1079af12e3dc8cdff90ae
Gerrit-Change-Number: 62909
Gerrit-PatchSet: 4
Gerrit-Owner: Robert Zieba
robertzieba@google.com
Gerrit-Reviewer: Anastasia Klimchuk
aklm@chromium.org
Gerrit-Reviewer: Diana Zigterman
dzigterman@google.com
Gerrit-Reviewer: Edward O'Callaghan
quasisec@chromium.org
Gerrit-Reviewer: Jon Murphy
jpmurphy@google.com
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Eric Peers
epeers@google.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-CC: Rob Barnes
robbarnes@google.com
Gerrit-Attention: Nico Huber
nico.h@gmx.de
Gerrit-Attention: Diana Zigterman
dzigterman@google.com
Gerrit-Attention: Edward O'Callaghan
quasisec@chromium.org
Gerrit-Attention: Anastasia Klimchuk
aklm@chromium.org
Gerrit-Attention: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Comment-Date: Wed, 13 Apr 2022 21:16:12 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nico Huber
nico.h@gmx.de
Comment-In-Reply-To: Anastasia Klimchuk
aklm@chromium.org
Gerrit-MessageType: comment