Attention is currently required from: Nico Huber, Diana Zigterman, Edward O'Callaghan, Anastasia Klimchuk, Karthik Ramasubramanian.

View Change

4 comments:

• File raiden_debug_spi.c:

  • Patch Set #3, Line 987:

    trailing space

    Done

  • Patch Set #3, Line 987:

    		/* Check if we received an error from the device. An error will have no response 
    		   data, just the packet_id and status_code. */
    

    While not expliticitly mentioned, even the Linux kernel accepts the […]

    Done

  • Patch Set #3, Line 989:

    trailing space

    Done

  • Patch Set #3, Line 990:

    sizeof(struct usb_spi_response_v2) - USB_SPI_PAYLOAD_SIZE_V2_RESPONSE &&
    			rsp_config.packet_v2.rsp_start.status_code != USB_SPI_SUCCESS) {
    

    Could you please add one more tab before these two lines? It would be easier to visually distinguish […]

    Done

To view, visit change 62909. To unsubscribe, or for help writing mail filters, visit settings.