Attention is currently required from: Nico Huber, Edward O'Callaghan, Angel Pons. Anastasia Klimchuk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/59742 )
Change subject: tests: Upgrade linux_spi test to run probe lifecycle ......................................................................
Patch Set 5:
(3 comments)
File tests/lifecycle.c:
https://review.coreboot.org/c/flashrom/+/59742/comment/a60c9ae7_9680a4b1 PS4, Line 18: #include <linux/spi/spidev.h> Ok thanks! I remember a conversation about libusb earlier. I will leave it.
put the code into a separate .c file, e.g. one specific to linux_spi tests
I might do it later for a different reason. I want to try and write extended version of chip tests, with real programmer not dummy. I can imagine, that would need more mocks and more code per programmer. However I want to finish probing lifecycle implementation first :)
https://review.coreboot.org/c/flashrom/+/59742/comment/5bd86458_16aaad1e PS4, Line 321: 0x40406b00
Isn't this covered by the include, something like `SPI_IOC_MESSAGE(2)`?
Oh yes! I probably wrote this line before I added the include.
https://review.coreboot.org/c/flashrom/+/59742/comment/964cbd2e_b7dbb1ee PS4, Line 327: readcnt == 3
Checking the actual command would be more accurate and not much harder, […]
Yes true, done.
-
Anastasia Klimchuk (Code Review)