Attention is currently required from: Nico Huber, Edward O'Callaghan, Angel Pons.

View Change

3 comments:

• File tests/lifecycle.c:

  • Patch Set #4, Line 18: #include <linux/spi/spidev.h>

    Ok thanks! I remember a conversation about libusb earlier. I will leave it.

    put the code into a separate .c file, e.g. one specific to linux_spi tests

    I might do it later for a different reason. I want to try and write extended version of chip tests, with real programmer not dummy. I can imagine, that would need more mocks and more code per programmer.
    However I want to finish probing lifecycle implementation first :)

  • Patch Set #4, Line 321: 0x40406b00

    Isn't this covered by the include, something like `SPI_IOC_MESSAGE(2)`?

    Oh yes! I probably wrote this line before I added the include.

  • Patch Set #4, Line 327: readcnt == 3

    Checking the actual command would be more accurate and not much harder, […]

    Yes true, done.

To view, visit change 59742. To unsubscribe, or for help writing mail filters, visit settings.