Change in flashrom[master]: Add support for reading the current flash contents from a file

[Paul Kocialkowski (Code Review)]

Paul Kocialkowski has posted comments on this change. ( https://review.coreboot.org/23263 )

Change subject: Add support for reading the current flash contents from a file
......................................................................

Patch Set 6:

(4 comments)

Oh well, I did have a few more suggestions in the end.

https://review.coreboot.org/#/c/23263/6/cli_classic.c
File cli_classic.c:

https://review.coreboot.org/#/c/23263/6/cli_classic.c@130
PS6, Line 130: 		{"ifd",			0, NULL, 0x0100},
wouldn't it make more sense to use the values from the enum here?

https://review.coreboot.org/#/c/23263/6/cli_classic.c@132
PS6, Line 132: 		{"flash-contents",	1, NULL, 0x0101},
ditto

https://review.coreboot.org/#/c/23263/6/cli_classic.c@253
PS6, Line 253: 		case 0x0101:
ditto, and there's probably a 0x0100 that's around but not shown in the context that should also be changed.

https://review.coreboot.org/#/c/23263/6/flashrom.c
File flashrom.c:

https://review.coreboot.org/#/c/23263/6/flashrom.c@2395
PS6, Line 2395: 	if (refcontents && oldcontents) {		
Extra padding should be removed.